Yeah, but a better person could be not-wrong without turning a single sentence criticism into a multi-paragraph rant only serving to stroke their ego. Turns out people can be “garbage” despite being skilled at something.
I don’t know, when you are dealing with this level of coding it should be top tier, and getting called out will make the person really review their next submission. The expectation that somebody always has to be nice to you while you fuckup, is not ideal. And I say that as a supervisor that is way too PC and nice to people whom unwittingly are sabotaging work, as a way to nurture them–but I honestly think it is counter productive
Cmon, this is not about naming, this is about non-generic code in generic header.
IMO hiding such a little operation behind a macro/function just hurt readability. Furthermore, considering that this function is only used once in the provided patch and that word ordering on RISC-V is not about to change anytime soon, it is perfectly fine to inline the code.
Making a u32 pointer from to u16’s isn’t a generic operation because it has to make assumptions about how the pointers work (in particular what endianess they have)
They named a function slightly poorly. As if Linus has never done that.
Not only that. They introduced a obscure function, which inner workings are not clear and that is only used by their new code into a global header which is used by many other code parts, which means other people could start using it. This could lead to bugs since the semantics are not clear from the function name or if they change the function in the future. Also they added their pull request much too late to be properly reviewed.
Linus doesn’t have to be a dick all the time. However, as I get older, I begin to understand the wisdom behind a monologue in Team America: World Police more and more:
We’re dicks! We’re reckless, arrogant, stupid dicks. And the Film Actors Guild are pussies. And Kim Jong Il is an asshole. Pussies don’t like dicks, because pussies get fucked by dicks. But dicks also fuck assholes: assholes that just want to shit on everything. Pussies may think they can deal with assholes their way. But the only thing that can fuck an asshole is a dick, with some balls. The problem with dicks is: they fuck too much or fuck when it isn’t appropriate - and it takes a pussy to show them that. But sometimes, pussies can be so full of shit that they become assholes themselves… because pussies are an inch and half away from assholes. I don’t know much about this crazy crazy world, but I do know this: if you don’t let us fuck this asshole, we’re going to have our dicks and pussies all covered in shit!
In this case, Linus is a dick who fucks when it’s not appropriate a lot (i.e., is harsh in his critique about bad code in pull requests). Assholes push bad code, and sometimes it’s so bad that it’ll fuck up the whole kernel. Pussies in tech magazines criticize his style of critique. Other pussies get “butt-hurt” because they code like shit too and they can’t or won’t admit it, and they’re so full of shit, they’re pussies who’ve become assholes themselves.
Linus moment. He isn’t wrong though
Yeah, but a better person could be not-wrong without turning a single sentence criticism into a multi-paragraph rant only serving to stroke their ego. Turns out people can be “garbage” despite being skilled at something.
I don’t know, when you are dealing with this level of coding it should be top tier, and getting called out will make the person really review their next submission. The expectation that somebody always has to be nice to you while you fuckup, is not ideal. And I say that as a supervisor that is way too PC and nice to people whom unwittingly are sabotaging work, as a way to nurture them–but I honestly think it is counter productive
Yeah or they’ll say “fuck this” and quit.
It’s hardly a fuck up. They named a function slightly poorly. As if Linus has never done that.
Cmon, this is not about naming, this is about non-generic code in generic header.
IMO hiding such a little operation behind a macro/function just hurt readability. Furthermore, considering that this function is only used once in the provided patch and that word ordering on RISC-V is not about to change anytime soon, it is perfectly fine to inline the code.
(a << 16) | bis about the most generic code you can get. How is that remotely RISC-V specific?Making a u32 pointer from to u16’s isn’t a generic operation because it has to make assumptions about how the pointers work (in particular what endianess they have)
What makes you think it’s making a pointer? Nobody said anything about that.
Not only that. They introduced a obscure function, which inner workings are not clear and that is only used by their new code into a global header which is used by many other code parts, which means other people could start using it. This could lead to bugs since the semantics are not clear from the function name or if they change the function in the future. Also they added their pull request much too late to be properly reviewed.
I read is rant, seems more than just a poor naming issue
Linus doesn’t have to be a dick all the time. However, as I get older, I begin to understand the wisdom behind a monologue in Team America: World Police more and more:
In this case, Linus is a dick who fucks when it’s not appropriate a lot (i.e., is harsh in his critique about bad code in pull requests). Assholes push bad code, and sometimes it’s so bad that it’ll fuck up the whole kernel. Pussies in tech magazines criticize his style of critique. Other pussies get “butt-hurt” because they code like shit too and they can’t or won’t admit it, and they’re so full of shit, they’re pussies who’ve become assholes themselves.
The code in question is, in fact, garbage.